OCPBUGS-32293: Update Jenkins test to use Deployment by apoorvajagtap · Pull Request #28718 · openshift/origin

apoorvajagtap · 2024-04-17T09:04:36Z

Failing Jenkins Pipeline test blocks multiple PRs from merging. As agreed, skipping these tests temporarily.

openshift-ci-robot · 2024-04-17T09:04:42Z

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-32293, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Failing Jenkins Pipeline test blocks multiple PRs from merging. As agreed, skipping these tests temporarily.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

apoorvajagtap · 2024-04-17T09:06:35Z

/assign @adambkaplan

adambkaplan

/approve

Minor suggestion on the skip message.

sayan-biswas · 2024-04-17T14:08:51Z

/approve

sayan-biswas · 2024-04-18T05:01:19Z

/lgtm

openshift-ci · 2024-04-18T05:03:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, apoorvajagtap, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/builds/OWNERS~~ [sayan-biswas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-04-18T05:38:59Z

/retest-required

Remaining retests: 0 against base HEAD 886b7ae and 2 for PR HEAD 809e832 in total

openshift-trt-bot · 2024-04-18T08:38:43Z

Job Failure Risk Analysis for sha: 809e832

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (18) are below the historical average (741): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-ci · 2024-04-18T12:19:06Z

New changes are detected. LGTM label has been removed.

apoorvajagtap · 2024-04-18T12:20:54Z

@adambkaplan While looking through the test logs, I realized that it creates deployment (template changes introduced with 4.15) & the test waits for deploymentConfig to be ready.
Instead of skipping, I have replaced the wait function, and I hope this will fix it. PTAL :)

adambkaplan · 2024-04-18T13:01:47Z

🤔 Now I'm wondering why it took us this long to catch the change...

sanchezl · 2024-04-18T20:07:34Z

/retest

sanchezl · 2024-04-18T18:15:53Z


 			g.By("waiting for jenkins deployment")
-			err = exutil.WaitForDeploymentConfig(oc.KubeClient(), oc.AppsClient().AppsV1(), oc.Namespace(), "jenkins", 1, false, oc)
+			err = exutil.WaitForDeploymentReady(oc, "jenkins", oc.Namespace())


In WaitForDeploymentReady, the context isn't wired through to the PollUntilContextTimeout's ConditionFunc. No rush to fix it now if the test is working, but FYI.

openshift-ci · 2024-04-18T23:33:52Z

@apoorvajagtap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node-serial	`ba2a8f0`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/e2e-gcp-ovn-builds	`ba2a8f0`	link	true	`/test e2e-gcp-ovn-builds`
ci/prow/e2e-aws-ovn-single-node-upgrade	`ba2a8f0`	link	false	`/test e2e-aws-ovn-single-node-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-trt-bot · 2024-04-18T23:36:05Z

Job Failure Risk Analysis for sha: ba2a8f0

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial	Low [sig-arch] events should not repeat pathologically for ns/openshift-etcd-operator This test has passed 49.30% of 71 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.

soltysh

/hold
Where that jenkins-ephemeral is coming from, I checked both https://github.com/openshift/origin/blob/master/examples/jenkins/jenkins-ephemeral-template.json and https://github.com/openshift/origin/blob/master/test/extended/testdata/cmd/test/cmd/testdata/jenkins/jenkins-ephemeral-template.json both of these are creating DCs not deployment?

Alternatively, if you're changing to a deployment (if the above what I said is wrong), you'll need to update logs command in line 65, it currently requests logs -f dc/jenkins which if we're working with a deployment should be logs -f deploy/jenkins

soltysh · 2024-04-19T12:03:36Z

Found the culprit in openshift/cluster-samples-operator#540, so yes, aside from that wait, you need to update that run as I mentioned above.

Also, given we have those two extra places which don't seem to be in-sync with what we have in samples, I'd suggest to sync them as well. To make them all consistent.

soltysh · 2024-04-19T12:04:04Z

/approve cancel
Please ping me directly on slack once all of the above is fixed, I don't want to have a half baked solution.

soltysh · 2024-04-19T13:18:40Z

Also DumpApplicationPodLogs works for DCs only, so that needs fixing as well.

soltysh · 2024-04-19T14:00:26Z

Reverting changes to cluster-samples-operator in openshift/cluster-samples-operator#542

adambkaplan · 2024-04-22T18:51:53Z

/close

Replacing with #28732

openshift-ci · 2024-04-22T18:52:14Z

@adambkaplan: Closed this PR.

Details

In response to this:

/close

Replacing with #28732

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2024-04-22T18:52:14Z

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-32293. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Failing Jenkins Pipeline test blocks multiple PRs from merging. As agreed, skipping these tests temporarily.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 17, 2024

openshift-ci Bot requested review from divyansh42 and sayan-biswas April 17, 2024 09:06

openshift-ci Bot assigned adambkaplan Apr 17, 2024

adambkaplan approved these changes Apr 17, 2024

View reviewed changes

Comment thread test/extended/builds/pipeline_origin_bld.go Outdated

skips jenkins pipeline build config strategy test

809e832

apoorvajagtap force-pushed the OCPBUGS-32293 branch from 688e448 to 809e832 Compare April 17, 2024 13:27

apoorvajagtap requested a review from adambkaplan April 17, 2024 13:28

sayan-biswas approved these changes Apr 17, 2024

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024

openshift-ci Bot assigned sayan-biswas Apr 18, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024

replaces deploymentconfig with deployment

ba2a8f0

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024

adambkaplan changed the title ~~OCPBUGS-32293: Skips Jenkins pipeline build config strategy test temporarily~~ OCPBUGS-32293: Update Jenkins test to use Deployment Apr 18, 2024

sanchezl mentioned this pull request Apr 18, 2024

NO-JIRA: bump openshift/kubernetes #28712

Merged

sanchezl reviewed Apr 18, 2024

View reviewed changes

soltysh suggested changes Apr 19, 2024

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024

soltysh mentioned this pull request Apr 19, 2024

OCPBUGS-20097: Switch to use cli image, as the scratch image #28695

Merged

soltysh removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024

openshift-ci Bot closed this Apr 22, 2024

Uh oh!

Conversation

apoorvajagtap commented Apr 17, 2024

Uh oh!

openshift-ci-robot commented Apr 17, 2024

Uh oh!

apoorvajagtap commented Apr 17, 2024

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sayan-biswas commented Apr 17, 2024

Uh oh!

sayan-biswas commented Apr 18, 2024

Uh oh!

openshift-ci Bot commented Apr 18, 2024

Uh oh!

openshift-ci-robot commented Apr 18, 2024

Uh oh!

openshift-trt-bot commented Apr 18, 2024

Uh oh!

openshift-ci Bot commented Apr 18, 2024

Uh oh!

apoorvajagtap commented Apr 18, 2024

Uh oh!

adambkaplan commented Apr 18, 2024

Uh oh!

sanchezl commented Apr 18, 2024

Uh oh!

sanchezl Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Apr 18, 2024

Uh oh!

openshift-trt-bot commented Apr 18, 2024

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

soltysh commented Apr 19, 2024

Uh oh!

soltysh commented Apr 19, 2024

Uh oh!

soltysh commented Apr 19, 2024

Uh oh!

soltysh commented Apr 19, 2024

Uh oh!

adambkaplan commented Apr 22, 2024

Uh oh!

openshift-ci Bot commented Apr 22, 2024

Uh oh!

openshift-ci-robot commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants